Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16939 add unit prefixes to data #3457

Merged

Conversation

macchiati
Copy link
Member

CLDR-16939

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@macchiati macchiati force-pushed the CLDR-16939-add-unit-prefixes-to-data branch from 6680bb0 to 70e6851 Compare January 22, 2024 05:04
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295
Copy link
Member

srl295 commented Jan 22, 2024

@macchiati as I wrote above, this is failing in the JSON tests

LdmlConvertRulesTest.testSplittableAttributes:98 set items missing from JSON configuration. To fix: Add to CHILD_VALUE_IS_SPACESEP_ARRAY, VALUE_IS_SPACESEP_ARRAY, or ATTRVALUE_AS_ARRAY_SET? ==> expected: <[]> but was: <[(unitPrefix,power10), (unitPrefix,power2), (unitPrefix,symbol)]>

@macchiati
Copy link
Member Author

macchiati commented Jan 22, 2024

When I look at the logs, I search for "error: ". What you are saying is that is resulting in huge numbers of false positives now, like:

Jan 21, 2024 9:11:56 PM org.unicode.cldr.test.CheckCLDR$CompoundCheckCLDR addError
SEVERE: Internal error: org.unicode.cldr.test.CheckExemplars in ko
java.lang.NullPointerException"

And I don't even see LdmlConvertRulesTest because everything is truncated.

…values has set/regex... instead of /regex, indicating that they were space separated. (Should also add a test for consistency of the annotations with whether we have NMTOKEN vs NMTOKENS.)
@macchiati
Copy link
Member Author

When I look at the logs, I search for "error: ". What you are saying is that is resulting in huge numbers of false positives now, like:

Just to close the loop, Steven explained why the changes happened, and that CLDR-17304 would fix them.

@macchiati macchiati merged commit 818a29c into unicode-org:main Jan 23, 2024
10 checks passed
@macchiati macchiati deleted the CLDR-16939-add-unit-prefixes-to-data branch January 23, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants